Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support openai base_url #180

Merged
merged 2 commits into from
Mar 15, 2024
Merged

feat: Support openai base_url #180

merged 2 commits into from
Mar 15, 2024

Conversation

bdqfork
Copy link
Contributor

@bdqfork bdqfork commented Mar 1, 2024

Support setting the OpenAI client base URL to enable OpenAI-style LLM (Language Model) services.

@jamescalam jamescalam changed the title Support openai base_url feat: Support openai base_url Mar 7, 2024
@jamescalam jamescalam self-assigned this Mar 7, 2024
@jamescalam jamescalam added the enhancement Enhancement to existing features label Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.96%. Comparing base (e02a4a7) to head (bc36616).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   77.95%   77.96%   +0.01%     
==========================================
  Files          42       42              
  Lines        2118     2119       +1     
==========================================
+ Hits         1651     1652       +1     
  Misses        467      467              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamescalam
Copy link
Member

@bdqfork thanks for the PR — could you fix the linting issues? We have instructions in contributor guidelines (number 5), ie:

  1. Ensure that All Pull Request Checks Pass There are Pull Request checks that need to be satifisfied before the changes can be merged. These appear towards the bottom of the Pull Request webpage on GitHub, and include:
  • Ensure that the Pull Request title is prepended with a valid type. E.g. feat: My New Feature.
    • Run linting (and fix any issues that are flagged) by:
    • Navigating to /semantic-router.
    • Running make lint to fix linting issues.
    • Running black . to fix black linting issues.
    • Running ruff . --fix to fix ruff linting issues (where possible, others may need manual changes).
    • Running mypy . and then fixing any of the issues that are raised.
    • Confirming the linters pass using make lint again.

Thanks!

@bdqfork
Copy link
Contributor Author

bdqfork commented Mar 8, 2024

@bdqfork thanks for the PR — could you fix the linting issues? We have instructions in contributor guidelines (number 5), ie:

  1. Ensure that All Pull Request Checks Pass There are Pull Request checks that need to be satifisfied before the changes can be merged. These appear towards the bottom of the Pull Request webpage on GitHub, and include:
  • Ensure that the Pull Request title is prepended with a valid type. E.g. feat: My New Feature.

    • Run linting (and fix any issues that are flagged) by:
    • Navigating to /semantic-router.
    • Running make lint to fix linting issues.
    • Running black . to fix black linting issues.
    • Running ruff . --fix to fix ruff linting issues (where possible, others may need manual changes).
    • Running mypy . and then fixing any of the issues that are raised.
    • Confirming the linters pass using make lint again.

Thanks!

@jamescalam Done!

@bdqfork
Copy link
Contributor Author

bdqfork commented Mar 13, 2024

@jamescalam Are there any other questions?

Copy link
Member

@jamescalam jamescalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @bdqfork

@jamescalam jamescalam merged commit d063a20 into aurelio-labs:main Mar 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants